[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

LGTM in general, modulo remaining nits.



================
Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:196
   void inferAddressSpaces(ArrayRef<WeakTrackingVH> Postorder,
-                          ValueToAddrSpaceMapTy *InferredAddrSpace) const;
+                          ValueToAddrSpaceMapTy *InferredAddrSpace,
+                          PredicatedAddrSpaceMapTy &PredicatedAS) const;
----------------
hliao wrote:
> tra wrote:
> > I think this could've been a reference, too.
> yeah, but we should address that in another change.
You're already changing function signatures.It would be reasonable to incorporate this cleanup, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112041/new/

https://reviews.llvm.org/D112041