[PATCH] D110867: X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 10:25:02 PDT 2021


MatzeB updated this revision to Diff 384505.
MatzeB added a comment.

- Fix EFLAGS live-out not triggering, even though we need to update CC flags for `ImmDelta != 0`.
- While on it rename `IsSafe` to the more descriptive `FlagsMayLiveOut`.
- Added new tests `opt_adjusted_imm_multiple_blocks`, `opt_adjusted_imm_multiple_blocks_noopt`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110867/new/

https://reviews.llvm.org/D110867

Files:
  llvm/lib/Target/X86/X86InstrInfo.cpp
  llvm/lib/Target/X86/X86InstrInfo.h
  llvm/test/CodeGen/X86/optimize-compare.mir
  llvm/test/CodeGen/X86/peep-test-5.ll
  llvm/test/CodeGen/X86/use-cr-result-of-dom-icmp-st.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110867.384505.patch
Type: text/x-patch
Size: 22036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211103/dd73fa8b/attachment.bin>


More information about the llvm-commits mailing list