[PATCH] D113073: [lld-macho] Cache library paths from findLibrary

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 08:45:26 PDT 2021


keith marked 2 inline comments as done.
keith added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1093
 
+    resolvedLibraries.clear();
     concatOutputSections.clear();
----------------
int3 wrote:
> ultra nit: can we make sure `resolvedLibraries.clear()` is next to `resolvedFrameworks.clear()`?
Sounds good I'll do that in the other diff since that one isn't reviewed yet


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113073/new/

https://reviews.llvm.org/D113073



More information about the llvm-commits mailing list