[PATCH] D113114: [lld-macho][nfc] Remove unnecessary -pie flags in tests

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 08:41:43 PDT 2021


oontvoo added inline comments.


================
Comment at: lld/test/MachO/tlv.s:6
 
-# RUN: %lld -lSystem -no_pie -o %t/regular %t/regular.o
-# RUN: llvm-otool -hv %t/regular | FileCheck %s --check-prefix=HEADER
-# RUN: llvm-objdump -d --bind --rebase %t/regular | FileCheck %s --check-prefixes=REG,LINKEDIT
-# RUN: llvm-objdump --macho --section=__DATA,__thread_vars %t/regular | \
+# RUN: %lld -lSystem -no_pie -o %t/regular-no-pie %t/regular.o
+# RUN: llvm-otool -hv %t/regular-no-pie | FileCheck %s --check-prefix=HEADER
----------------
oontvoo wrote:
> don't we need a space here? 
> (same with others `-no-pie` arg)
Bleh - this is not the arg - it's the file name. 
Ignore me!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113114/new/

https://reviews.llvm.org/D113114



More information about the llvm-commits mailing list