[PATCH] D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf)

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:229-289
+enum perf_type_id {
+  PERF_TYPE_HARDWARE = 0,
+  PERF_TYPE_SOFTWARE = 1,
+  PERF_TYPE_TRACEPOINT = 2,
+  PERF_TYPE_HW_CACHE = 3,
+  PERF_TYPE_RAW = 4,
+  PERF_TYPE_BREAKPOINT = 5,
----------------
Is there no perf header that we could add to the tree?


================
Comment at: lnt/testing/profile/cPerf.cpp:708-712
     // EXEC ELF objects aren't relocated. DYN ones are,
     // so if it's a DYN object adjust by subtracting the
     // map base.
-    bool IsSO = IsSharedObject(Maps[MapID].Filename);
-    uint64_t Adjust = IsSO ? Maps[MapID].Start : 0;
----------------
Why is this no longer needed? You should adapt/remove the comment accordingly.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112411/new/

https://reviews.llvm.org/D112411