[PATCH] D113095: Combine FADD and FMUL aarch64 intrinsics to FMLA

Matt Devereau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 07:53:19 PDT 2021


MattDevereau added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:701
+  // fold (fadd p a (fmul p b c)) -> (fma p a b c)
+  Value *p = II.getOperand(0);
+  Value *a = II.getOperand(1);
----------------
paulwalker-arm wrote:
> These should be upper case to match LLVM styling and be consistent with the other names using within this patch.
I'm not 100% sure what you mean by "these" being consistent with the other names

p -> P
a -> A
b -> B
c -> C
FMul -> FMUL?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113095/new/

https://reviews.llvm.org/D113095



More information about the llvm-commits mailing list