[PATCH] D113063: [lld-macho] Cache discovered framework paths

[Keith Smiley via Phabricator via llvm-commits]

keith added inline comments.


================
Comment at: lld/MachO/Driver.cpp:117-119
+          auto saved = saver.save(suffixed.str());
+          resolvedPaths[key] = saved;
+          return saved;
----------------
int3 wrote:
> code style is to use explicit type names instead of `auto` unless the type is something complicated like an iterator
> 
> also I would personally prefer `return resolvedPaths[key] = second;`, but up to you
Thanks for the feedback! Updated accordingly.

Is it possible for us to setup some automation here to flag these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113063/new/

https://reviews.llvm.org/D113063