[PATCH] D113073: [lld-macho] Cache library paths from findLibrary

[Keith Smiley via Phabricator via llvm-commits]

keith added inline comments.


================
Comment at: lld/MachO/Driver.cpp:85-106
+  CachedHashStringRef key(name);
+  auto entry = resolvedLibraries.find(key);
+  if (entry != resolvedLibraries.end())
+    return entry->second;
+
   if (config->searchDylibsFirst) {
     if (Optional<StringRef> path = findPathCombination(
----------------
int3 wrote:
> keith wrote:
> > oontvoo wrote:
> > > 
> > Ah great idea, thanks!
> what value does the lambda add here?
IMO the reduced duplication is a big benefit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113073/new/

https://reviews.llvm.org/D113073