[PATCH] D113070: [lld-macho] Silently ignore the -objc_abi_version

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 18:32:25 PDT 2021


keith added inline comments.


================
Comment at: lld/MachO/Options.td:1331
+
+def grp_ignored_silently : OptionGroup<"ignored_silently">, HelpText<"IGNORED SILENTLY">;
+
----------------
oontvoo wrote:
> Why do we need this?  Doesn't removing the `Flags<HelpHidden>` effectively ignore it silently?
> 
> (should also add a test to silent-ignore.test)
This is primarily for the C++ change that stops this category from printing a warning. That's what silently means in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113070/new/

https://reviews.llvm.org/D113070



More information about the llvm-commits mailing list