[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:71-72
 
+        defined->referencedDynamically |= isReferencedDynamically;
+        defined->noDeadStrip |= noDeadStrip;
+
----------------
int3 wrote:
> is this what ld64 does for these two attributes too? (can we test it?)
No, this is NOT what LD64 does. (In fact this was one of the differences I was trying to note in the draft doc a couple weeks ago).
LD64 picks one of the two (based on things like scope,  alignment, whether symbols are auto-hide ) and doesn't merge anything.
I guess we could imitate that here ... didn't want to change that since this current approach seems to be working fine...




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977