[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind
Vy Nguyen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 2 14:35:34 PDT 2021
oontvoo marked an inline comment as done and an inline comment as not done.
oontvoo added inline comments.
================
Comment at: lld/MachO/SymbolTable.cpp:69-74
+ defined->referencedDynamically |= isReferencedDynamically;
+ defined->noDeadStrip |= noDeadStrip;
+
+ if (auto concatIsec = dyn_cast_or_null<ConcatInputSection>(isec))
+ concatIsec->wasCoalesced = true;
return defined;
----------------
int3 wrote:
> why are we moving these outside the `if` block? we should be coalescing away the subsection associated with the weak symbol, but not the subsection associated with the non-weak symbol
Yes, for this if-branch (ie., both are weak, then we're coalescing the new one)
For the other branch, we're coalescing the weak symbol's (ie., the old one)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112977/new/
https://reviews.llvm.org/D112977
More information about the llvm-commits
mailing list