[PATCH] D113051: [AArch64] Diagnose large adrp offset on Windows.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:164
+    if (TheTriple.isOSBinFormatCOFF()) {
+      if (SignedValue > 2097151 || SignedValue < -2097152)
+        Ctx.reportError(Fixup.getLoc(), "fixup value out of range");
----------------
Nit: It's not entirely obvious to the reader that these decimal numbers map to the limits of a signed 21 bit number corresponding to the mask below (although that's the main thing one would guess that they mean).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113051/new/

https://reviews.llvm.org/D113051