[PATCH] D112450: support xcoff for llvm-nm
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 2 13:55:19 PDT 2021
DiggerLin marked 3 inline comments as done.
DiggerLin added a comment.
In D112450#3102179 <https://reviews.llvm.org/D112450#3102179>, @jhenderson wrote:
> Let's keep this bare-bones for now, and split off the size extraction and name demangling into separate patches.
I agree with you that it may be better to split the patch into three at begin . Since I have implemented all these functionality together and there is not a lot of code change in the "size extraction" and "name demangling" , I do not think we can get a lot of benefit from putting effort to split the patch into three now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112450/new/
https://reviews.llvm.org/D112450
More information about the llvm-commits
mailing list