[PATCH] D112337: [DebugInfo] Only create concrete DIEs of concrete functions

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 11:11:11 PDT 2021


dblaikie added a comment.

In D112337#3103579 <https://reviews.llvm.org/D112337#3103579>, @ellis wrote:

> @dblaikie Turns out that since outlined machine functions are created during codegen, we can't see that those SPs are concrete during `beginModule()`. I've left `ProcessedSPNodes` how it was (which does include outlined SPs) and added comments to `ConcreteSPs`.

Does that not cause problems for the strategy in general? Wouldn't this mean new concrete subprograms would show up and break the assumptions made that only ConcreteSPs are the ones that need to be separated from the abstract definition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112337/new/

https://reviews.llvm.org/D112337



More information about the llvm-commits mailing list