[PATCH] D113030: Add a new tool for parallel safe bisection, "llvm-bisectd".

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/docs/Bisection.md:41
+
+For our example of bisecting a novel optimization pass, a good choice of key
+would be the module + function name of the target program being compiled. The
----------------
In the GISel example patch, you disambiguate further using the target. Should you mention that here?


================
Comment at: llvm/docs/Bisection.md:77
+just replies to the clients with the answer "YES". In the background, it's
+storing each unique key it receives into a vector for later.
+
----------------
"into a vector" seems like an implementation detail


================
Comment at: llvm/docs/Bisection.md:119
+  // ...
+  if (EnableBisectForNewOptimization) {
+    std::string Key = F.getParent()->getSourceFileName() + " "
----------------
Should bisector support be only included in assert/debug builds?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113030/new/

https://reviews.llvm.org/D113030