[PATCH] D113032: [ArgPromo] Preserve FunctionAnalysisManagerCGSCCProxy

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 10:26:59 PDT 2021


aeubanks created this revision.
aeubanks added a reviewer: asbirlea.
Herald added subscribers: ormris, hiraditya.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We already make sure to properly clear analyses for deleted functions.

This makes investigating some future potential compile time improvements easier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113032

Files:
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp


Index: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
===================================================================
--- llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
+++ llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
@@ -1051,7 +1051,10 @@
   if (!Changed)
     return PreservedAnalyses::all();
 
-  return PreservedAnalyses::none();
+  PreservedAnalyses PA;
+  // We've cleared out analyses for deleted functions.
+  PA.preserve<FunctionAnalysisManagerCGSCCProxy>();
+  return PA;
 }
 
 namespace {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113032.384152.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211102/7610b8c5/attachment.bin>


More information about the llvm-commits mailing list