[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from some possible nits.



================
Comment at: clang/lib/Serialization/ASTWriter.cpp:5018
         Record.AddStmt(A->getAllocator());
+        Record.AddStmt(A->getAlignment());
         Record.AddSourceRange(A->getRange());
----------------
This can potentially add a null statement to emit to the serialized form.


================
Comment at: clang/lib/Serialization/ASTWriter.cpp:6224
+void OMPClauseWriter::VisitOMPAlignClause(OMPAlignClause *C) {
+  Record.AddStmt(C->getAlignment());
+  Record.AddSourceLocation(C->getLParenLoc());
----------------
Same for this one, maybe?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112577/new/

https://reviews.llvm.org/D112577