[PATCH] D113014: [fir] Add fir.zero_bits conversion pattern to LLVM IR dialect

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added inline comments.


================
Comment at: flang/test/Fir/convert-to-llvm.fir:121
+  %z0 = fir.zero_bits f16
+  %z1 = fir.zero_bits f32
+  %z2 = fir.zero_bits f64
----------------
kiranchandramohan wrote:
> What about f80 and f24?
Added `bf16` and `f80`. 


================
Comment at: flang/test/Fir/convert-to-llvm.fir:129
+// CHECK: %{{.*}} = llvm.mlir.constant(0.000000e+00 : f32) : f32
+// CHECK: %{{.*}} = llvm.mlir.constant(0.000000e+00 : f128) : f128
+// CHECK-NOT: fir.zero_bits
----------------
kiranchandramohan wrote:
> Missed f64.
Thanks for catching this. This is fixed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113014/new/

https://reviews.llvm.org/D113014