[PATCH] D111862: [AArch64] Canonicalize X*(Y+1) or X*(1-Y) to madd/msub

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 04:45:06 PDT 2021


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Looks like you've addressed all the review comments.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13012
+  SDValue MulOper;
+  unsigned Opc;
+
----------------
nit: Could you rename this so it's more obvious, i.e. something like `AddSubOpc`? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111862/new/

https://reviews.llvm.org/D111862



More information about the llvm-commits mailing list