[PATCH] D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked 2 inline comments as done.
gbreynoo added a comment.

I have also removed the successful test case from dwarf_invalid.yaml.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/debug-vars-dwarf4.s:48
 # RUN:     FileCheck %s --check-prefix=ASCII --strict-whitespace
+# RUN:     not llvm-objdump - -d --debug-vars=bad_value 2>&1 | \
+# RUN:     FileCheck %s --check-prefix=ERROR
----------------
jhenderson wrote:
> I don't think this is going to do what you think it will.
> 
> I //think// you're trying to feed the llvm-mc output into llvm-objdump (the `-` means read input from stdin), but you aren't piping any llvm-mc output into llvm-objdump.
As the commandline parsing gave the error before the validity of the input was checked I didn't think we needed this line. To avoid confusion I have added the input.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112183/new/

https://reviews.llvm.org/D112183