[PATCH] D109749: Experimental Partial Mem2Reg

[Graham Hunter via Phabricator via llvm-commits]

huntergr added a comment.





================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4715-4720
+    // We're only interested if the alloca is used by a non-intrinsic
+    // call instruction...
+    if (!any_of(AI->users(), [](const User *U) {
+          return isa<CallInst>(U) && !isa<IntrinsicInst>(U);
+        }))
+      continue;
----------------
lebedev.ri wrote:
> This isn't right. What if not the `alloca`, but `gep(alloca)`, is passed into the function?
Ah, good catch. I'll fix that and add some more test cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109749/new/

https://reviews.llvm.org/D109749