[PATCH] D112994: [AArch64] Sink splat shuffles to lane index intrinsics
Sam Tebbs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 2 03:26:20 PDT 2021
samtebbs added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11933-11941
+ case Intrinsic::aarch64_neon_sqdmull:
+ case Intrinsic::aarch64_neon_sqdmulh:
+ case Intrinsic::aarch64_neon_sqrdmulh:
+ // Sink splats for index lane variants
+ if (isSplatShuffle(II->getOperand(0)))
+ Ops.push_back(&II->getOperandUse(0));
+ if (isSplatShuffle(II->getOperand(1)))
----------------
I don't know much about the sinking test coverage, but would a test for when `Ops` is empty here be beneficial?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112994/new/
https://reviews.llvm.org/D112994
More information about the llvm-commits
mailing list