[PATCH] D112711: [fir] Add FIR CSE specific pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D112711#3098053 <https://reviews.llvm.org/D112711#3098053>, @mehdi_amini wrote:

> Right so I'm interested in what it'll take to converge this with the existing CSE pass. What you mentioned here is interesting because it seems all in the domain of memory effects I believe: does it point mostly to the lack of support for the memory effects op interface in the CSE pass?

I think what difference we have right now with the memory effects op interface is that in the case of the memory effects op interface it applies to a op all the time. In our case, the `fir.call` can be `pure` or not. I'm not sure how this would work with the memory effects. It would probably requires two distincts operations or I'm missing something. Sorry, I'm not be up to date with the current memory effects op interface (will have a look at it today to refresh my knowledge :-) ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112711/new/

https://reviews.llvm.org/D112711