[PATCH] D27219: Add MCNoDeprecatedASM into MC ASMParser TargetOption to have an option to disable deprecate warning in asm

Yi Kong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 02:37:59 PDT 2021


kongyi added inline comments.
Herald added a subscriber: kristof.beyls.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp:3202
     OS << "    std::string Info;\n";
-    OS << "    if (MII.get(Inst.getOpcode()).getDeprecatedInfo(Inst, getSTI(), Info)) {\n";
+    OS << "    if (!getParser().getTargetParser().\n";
+    OS << "        getTargetOptions().MCNoDeprecatedWarn &&\n";
----------------
echristo wrote:
> What's with the TargetParser check here?
> 
This is not a check (see the trailing ".")

The format is quite confusing, fixing it in https://reviews.llvm.org/D112993.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D27219/new/

https://reviews.llvm.org/D27219



More information about the llvm-commits mailing list