[PATCH] D112919: [CSKY] Add CSKY 16-bit instruction format and encoding

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/CSKY/CSKY.td:28
 
+def FeatureJAVA
+    : SubtargetFeature<"java", "HasJAVA", "true", "Enable java instructions">;
----------------
rengolin wrote:
> Huh! I haven't found any reference to Java instructions in either available manuals (in github).
> 
> I'm guessing this is similar to Arm's Jazelle extensions?
> 
> None of the instructions below marked with `HasJAVA` appear on the ISA document...
> 
> Perhaps better to leave it out for another commit once that part is public?
for example, BPOPH has reference to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112919/new/

https://reviews.llvm.org/D112919