[PATCH] D111337: [fir] Add array value copy pass

Tue Nov 2 01:55:57 PDT 2021

clementval marked an inline comment as done.
clementval added a comment.

In D111337#3100539 <https://reviews.llvm.org/D111337#3100539>, @mehdi_amini wrote:

> Testing is better now, thanks!
> I haven't seen a follow up on https://reviews.llvm.org/D111288#inline-1071935 ; but this is a recurring issue that affects this revision as well.

@mehdi_amini I have updated this patch and removed some `auto` occurrences. As mentioned we will post soon a small guideline for Flang doc that precise that we are using the MLIR style in folder related to MLIR (Optimizer, Lower) and precise how we use `auto`. Don't worry it is not a "use `auto` everywhere" but rather a clarification of the LLVM guidelines that is somewhat open. I have looked through the MLIR codebase and I think we are pretty much on par with the use of `auto`. 
I hope we can move forward with this patch now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337