[PATCH] D111699: [XCOFF] [llvm-readobj] replace tests using binary as input with tests generated by yaml2obj.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/sections.test:7
 
-# SEC32:     File: {{.*}}basic.o
-# SEC32-NEXT:  Format: aixcoff-rs6000
-# SEC32-NEXT:  Arch: powerpc
-# SEC32-NEXT:  AddressSize: 32bit
-# SEC32-NEXT:  Sections [
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 1
-# SEC32-NEXT:      Name: .text
-# SEC32-NEXT:      PhysicalAddress: 0x0
-# SEC32-NEXT:      VirtualAddress: 0x0
-# SEC32-NEXT:      Size: 0x100
-# SEC32-NEXT:      RawDataOffset: 0x200
-# SEC32-NEXT:      RelocationPointer: 0x3D8
-# SEC32-NEXT:      LineNumberPointer: 0x4E6
-# SEC32-NEXT:      NumberOfRelocations: 8
-# SEC32-NEXT:      NumberOfLineNumbers: 12
-# SEC32-NEXT:      Type: STYP_TEXT (0x20)
-# SEC32-NEXT:    }
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 2
-# SEC32-NEXT:      Name: .data
-# SEC32-NEXT:      PhysicalAddress: 0x100
-# SEC32-NEXT:      VirtualAddress: 0x100
-# SEC32-NEXT:      Size: 0x68
-# SEC32-NEXT:      RawDataOffset: 0x300
-# SEC32-NEXT:      RelocationPointer: 0x428
-# SEC32-NEXT:      LineNumberPointer: 0x0
-# SEC32-NEXT:      NumberOfRelocations: 19
-# SEC32-NEXT:      NumberOfLineNumbers: 0
-# SEC32-NEXT:      Type: STYP_DATA (0x40)
-# SEC32-NEXT:    }
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 3
-# SEC32-NEXT:      Name: .bss
-# SEC32-NEXT:      PhysicalAddress: 0x168
-# SEC32-NEXT:      VirtualAddress: 0x168
-# SEC32-NEXT:      Size: 0x4
-# SEC32-NEXT:      RawDataOffset: 0x0
-# SEC32-NEXT:      RelocationPointer: 0x0
-# SEC32-NEXT:      LineNumberPointer: 0x0
-# SEC32-NEXT:      NumberOfRelocations: 0
-# SEC32-NEXT:      NumberOfLineNumbers: 0
-# SEC32-NEXT:      Type: STYP_BSS (0x80)
-# SEC32-NEXT:    }
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 4
-# SEC32-NEXT:      Name: .tdata
-# SEC32-NEXT:      PhysicalAddress: 0x0
-# SEC32-NEXT:      VirtualAddress: 0x0
-# SEC32-NEXT:      Size: 0x4
-# SEC32-NEXT:      RawDataOffset: 0x368
-# SEC32-NEXT:      RelocationPointer: 0x47A
-# SEC32-NEXT:      LineNumberPointer: 0x0
-# SEC32-NEXT:      NumberOfRelocations: 0
-# SEC32-NEXT:      NumberOfLineNumbers: 0
-# SEC32-NEXT:      Type: STYP_TDATA (0x400)
-# SEC32-NEXT:    }
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 5
-# SEC32-NEXT:      Name: .tbss
-# SEC32-NEXT:      PhysicalAddress: 0x4
-# SEC32-NEXT:      VirtualAddress: 0x4
-# SEC32-NEXT:      Size: 0x8
-# SEC32-NEXT:      RawDataOffset: 0x0
-# SEC32-NEXT:      RelocationPointer: 0x0
-# SEC32-NEXT:      LineNumberPointer: 0x0
-# SEC32-NEXT:      NumberOfRelocations: 0
-# SEC32-NEXT:      NumberOfLineNumbers: 0
-# SEC32-NEXT:      Type: STYP_TBSS (0x800)
-# SEC32-NEXT:    }
-# SEC32-NEXT:    Section {
-# SEC32-NEXT:      Index: 6
-# SEC32-NEXT:      Name: .debug
-# SEC32-NEXT:      PhysicalAddress: 0x0
-# SEC32-NEXT:      VirtualAddress: 0x0
-# SEC32-NEXT:      Size: 0x6C
-# SEC32-NEXT:      RawDataOffset: 0x36C
-# SEC32-NEXT:      RelocationPointer: 0x0
-# SEC32-NEXT:      LineNumberPointer: 0x0
-# SEC32-NEXT:      NumberOfRelocations: 0
-# SEC32-NEXT:      NumberOfLineNumbers: 0
-# SEC32-NEXT:      Type: STYP_DEBUG (0x2000)
-# SEC32-NEXT:    }
-# SEC32-NEXT:  ]
+# SEC32:Format: aixcoff-rs6000
+# SEC32-NEXT:Arch: powerpc
----------------
See inline edit, for a tip for the future (no need to change this now unless you want to). This ensures the `:` characters all line up, meaning your text is all lined up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111699/new/

https://reviews.llvm.org/D111699