[PATCH] D109860: profi - a flow-based profile inference algorithm: Part I (out of 3)

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h:758
+  // of SampleProfileLoaderBaseImpl.
+  if (SampleProfileUseProfi && std::is_same<BT, BasicBlock>::value) {
+    // Prepare block sample counts for inference.
----------------
Performance and count quality aside, can we make it work with MIR here just to make sure functionality is there. i.e. we can probably have a test case for MIR+Profi using FS-AFDO. Making sure it generates better count for MIR can be dealt with separately later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109860/new/

https://reviews.llvm.org/D109860