[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo created this revision.
oontvoo added a reviewer: int3.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
oontvoo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently registerCompactUnwind()  is called before ICF ever runs, so the assert(wasCoalesced) can't ever be true.
Similarly, assert(wasCoalesced) can't be true if ICF is not run (ie.,icfLevel == none)

The change here was to move the registerCompactUnwind to after ICF.

PR/52372


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D112977

Files:
  lld/MachO/Driver.cpp
  lld/MachO/InputFiles.cpp
  lld/MachO/InputFiles.h
  lld/test/MachO/weak-sym.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112977.383943.patch
Type: text/x-patch
Size: 4824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211102/6b9714fa/attachment.bin>