[PATCH] D112948: [SamplePGO] Fix callsite sample lookup to use dwarf names when dwarf linkage name isn't available.
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 1 18:23:48 PDT 2021
wenlei added inline comments.
================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:233-234
+ unsigned Discriminator;
+ if (ProfileIsFS)
+ Discriminator = DIL->getDiscriminator();
+ else
----------------
This is not NFC change because getCallSiteIdentifier has other call sites too other than the one from findFunctionSamples. Can we avoid this change and stick to linkage name fix only?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112948/new/
https://reviews.llvm.org/D112948
More information about the llvm-commits
mailing list