[PATCH] D107378: Make enum iteration with seq safe by default

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 16:25:09 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.

Sounds OK to me - maybe cleanup/improve the force_iteration_on_noniterable_enum to work like other tags (such as `llvm::None` and `std::piecewise_construct`).



================
Comment at: llvm/include/llvm/Support/MachineValueType.h:1438
+                                MVT::LAST_SCALABLE_VECTOR_VALUETYPE,
+                                force_iteration_on_noniterable_enum{});
     }
----------------
Perhaps force_iteration_on_noniterable_enum could be a const variable (like `llvm::None`) so callers don't have to use `{}`? (like other tags such as `piecewise_construct`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378



More information about the llvm-commits mailing list