[PATCH] D112953: [WebAssembly] support "return" and unreachable code in asm type checker

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 15:33:54 PDT 2021


dschuff accepted this revision.
dschuff added a comment.

Are there any type checker tests that are expected to fail?



================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:77
     return true;
+  // If we're currently in unreachable code, we surpress errors as well.
+  if (Unreachable)
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112953/new/

https://reviews.llvm.org/D112953



More information about the llvm-commits mailing list