[PATCH] D112942: target ABI: improve call parameters extensions handling

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: aeubanks.
rnk added a comment.

Seems reasonable to me. + at aeubanks, can you review this? I think you ran into these issues with SystemZ extension attributes when you made that change to only look at call site ABI attributes.



================
Comment at: llvm/include/llvm/IR/Attributes.td:139
 
+/// No extension needed before/after call (struct in reg).
+def NoExt : EnumAttr<"noext", [ParamAttr, RetAttr]>;
----------------
This is not SystemZ-specific, so instead of "struct in reg" I suggest "high bits are undefined". That should be accurate when this attribute is used on any target.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112942/new/

https://reviews.llvm.org/D112942