[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1464
+  printer << "from [";
+  StringRef comma = "";
+  // Even entries are the lower bounds.
----------------
Did you miss the comma here? 
There might be a missing multi-coordinate test.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1470
+  printer << "] to [";
+  // Odd entries are the lower bounds.
+  for (auto coor : llvm::enumerate(coord.getValues<int64_t>()))
----------------
upper bounds?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899