[PATCH] D112811: [ARM] implement LOAD_STACK_GUARD for remaining targets
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 1 14:14:14 PDT 2021
mstorsjo added a comment.
In D112811#3097762 <https://reviews.llvm.org/D112811#3097762>, @nickdesaulniers wrote:
> Changes LGTM; let's wait for @mstorsjo to triple check the COFF related changes, since I'm almost completely unaware of the details of that object file format. Thanks for the patch (and splitting it up, making it easier to review)!
The change to the testcase looks correct given the description of the commit, and the reasoning around `isGVIndirectSymbol` seems correct too. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112811/new/
https://reviews.llvm.org/D112811
More information about the llvm-commits
mailing list