[PATCH] D111902: [llvm-profgen] Warn on invalid range and show warning summary

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:447
+
+  emitWarningSummary(
+      AllUntrackedCallsites.size(), SampleCounters.size(),
----------------
How about emit summary before the detailed messages?


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:1043
+
+static const std::string EndNotBoundaryMsg =
+    "Range end is not on instruction boundary.";
----------------
Make these static fields of PerfScriptReader? `static const char*` should be fine.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:404
 
+      if (MCDesc.isTerminator())
+        TerminatorOffsets.insert(Offset);
----------------
Is this supposed to identify a branch instruction? `BranchAddrs` may sound easier to understand?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111902/new/

https://reviews.llvm.org/D111902