[PATCH] D112946: Remove unused builder from InsertOnRangeOp (NFC)

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 13:41:11 PDT 2021


clementval added a comment.

In D112946#3101041 <https://reviews.llvm.org/D112946#3101041>, @mehdi_amini wrote:

> In D112946#3101033 <https://reviews.llvm.org/D112946#3101033>, @clementval wrote:
>
>> The pre-merge checks are failing during the build. Looks like there is a use of the builder somewhere.
>
> Indeed it was passing before I removed the declaration, which I think shows that this is dead code, but transitively speaking!

This is probably left over from the version of the op that had values instead of attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112946/new/

https://reviews.llvm.org/D112946



More information about the llvm-commits mailing list