[PATCH] D112826: [CodeView] Fortran debug info emission in Code View.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1667
 }
 
 TypeIndex CodeViewDebug::lowerTypeBasic(const DIBasicType *Ty) {
----------------
Similarly, please put the lowerTypeString implementation here.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2389-2391
+  TypeIndex ResultType = TypeTable.writeLeafType(AR);
+
+  return ResultType;
----------------
This can be simplified to `return TypeTable.writeLeafType(AR);`.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h:409
   codeview::TypeIndex lowerTypeAlias(const DIDerivedType *Ty);
   codeview::TypeIndex lowerTypeArray(const DICompositeType *Ty);
   codeview::TypeIndex lowerTypeBasic(const DIBasicType *Ty);
----------------
This is a bit nitty, but I place the new declaration here after lowerTypeArray, since that's the most related code, not the composite type handling code.


================
Comment at: llvm/test/DebugInfo/fortran-basic.ll:1
+; RUN: llc < %s -filetype=obj | llvm-readobj - --codeview | FileCheck %s
+;
----------------
Do you find the output of `llvm-pdbutil dump -symbols -types` more readable in this case? If so, I recommend it over `llvm-readobj`. It is more FileCheck-friendly because the CHECK lines that match the type indexes contain more disambiguating context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112826/new/

https://reviews.llvm.org/D112826