[PATCH] D112472: [Scalarizer] Do not insert instructions between PHI nodes.

Daniele Vettorel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 10:41:40 PDT 2021


vettoreldaniele added a comment.

In D112472#3100590 <https://reviews.llvm.org/D112472#3100590>, @bjope wrote:

> So I wouldn't mind if we try to solve both problems here (by using some kind of helper such as `skipPastPhiNodesAndDbg `from the downstream patch I refer to above).
>
> Let me know if you for example want me to pre-commit the test case for the debug-invariance problem.
> Or if you want to focus on the phi node problem at first, then I can follow up with a patch that also skips past the dbg intrinsics.

Hi Bjorn,

Thanks for letting me know about this. I'm happy to fix both problems with this patch and add the test case you provided for debug instructions as well.

I'll update this patch soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112472/new/

https://reviews.llvm.org/D112472



More information about the llvm-commits mailing list