[PATCH] D110527: [llvm-reduce] Add MIR support.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

In D110527#3095676 <https://reviews.llvm.org/D110527#3095676>, @markus wrote:

> In D110527#3093880 <https://reviews.llvm.org/D110527#3093880>, @lebedev.ri wrote:
>
>> Do these tools have anything in common other than the delta algorithm?
>
> I would say that the tools are almost identical except that they work on different representations (IR and MIR). The purpose of the tools are the same, the command line interface, the handling of temporary files and the execution of interestingness tests are all the same and of course the main component the delta algorithm is the same.
>
>> Will *any* pass be shared?
>
> The passes are unlikely to ever be shared as they are specific to the representation.
>
> One can of course go the other way around and split the tools, refactor to make the common parts reusable (and put them in some lib somewhere) but to me that seems like a much larger change and the code duplication will be higher. This is what we have right now. Either way is doable but none of the alternatives are likely to please everyone.

I agree at least for now. Currently I think the overhead of maintaining two llvm-reduces would be much larger than the problems that arise from sharing code. This may change in the future, and then we should consider splitting them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110527/new/

https://reviews.llvm.org/D110527