[llvm] b8016b6 - [CodeGen] Tweak coding style in LivePhysRegs::stepForward. NFC.
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 1 09:03:54 PDT 2021
Author: Jay Foad
Date: 2021-11-01T16:01:24Z
New Revision: b8016b626ec7095c7d57ebfffb2135dc5c3077b8
URL: https://github.com/llvm/llvm-project/commit/b8016b626ec7095c7d57ebfffb2135dc5c3077b8
DIFF: https://github.com/llvm/llvm-project/commit/b8016b626ec7095c7d57ebfffb2135dc5c3077b8.diff
LOG: [CodeGen] Tweak coding style in LivePhysRegs::stepForward. NFC.
Added:
Modified:
llvm/lib/CodeGen/LivePhysRegs.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/LivePhysRegs.cpp b/llvm/lib/CodeGen/LivePhysRegs.cpp
index c0c7848139e4..6841b2dd7a15 100644
--- a/llvm/lib/CodeGen/LivePhysRegs.cpp
+++ b/llvm/lib/CodeGen/LivePhysRegs.cpp
@@ -81,22 +81,24 @@ void LivePhysRegs::stepForward(const MachineInstr &MI,
SmallVectorImpl<std::pair<MCPhysReg, const MachineOperand*>> &Clobbers) {
// Remove killed registers from the set.
for (ConstMIBundleOperands O(MI); O.isValid(); ++O) {
- if (O->isReg() && !O->isDebug()) {
+ if (O->isReg()) {
+ if (O->isDebug())
+ continue;
Register Reg = O->getReg();
- if (!Register::isPhysicalRegister(Reg))
+ if (!Reg.isPhysical())
continue;
if (O->isDef()) {
// Note, dead defs are still recorded. The caller should decide how to
// handle them.
Clobbers.push_back(std::make_pair(Reg, &*O));
} else {
- if (!O->isKill())
- continue;
assert(O->isUse());
- removeReg(Reg);
+ if (O->isKill())
+ removeReg(Reg);
}
- } else if (O->isRegMask())
+ } else if (O->isRegMask()) {
removeRegsInMask(*O, &Clobbers);
+ }
}
// Add defs to the set.
@@ -296,7 +298,7 @@ void llvm::recomputeLivenessFlags(MachineBasicBlock &MBB) {
Register Reg = MO->getReg();
if (Reg == 0)
continue;
- assert(Register::isPhysicalRegister(Reg));
+ assert(Reg.isPhysical());
bool IsNotLive = LiveRegs.available(MRI, Reg);
@@ -325,7 +327,7 @@ void llvm::recomputeLivenessFlags(MachineBasicBlock &MBB) {
Register Reg = MO->getReg();
if (Reg == 0)
continue;
- assert(Register::isPhysicalRegister(Reg));
+ assert(Reg.isPhysical());
bool IsNotLive = LiveRegs.available(MRI, Reg);
MO->setIsKill(IsNotLive);
More information about the llvm-commits
mailing list