[PATCH] D112735: export unique symbol list for xcoff with llvm-objdump new option "--export-unique-symbol"

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 08:23:19 PDT 2021


jhenderson added a comment.

Does this option really belong in llvm-objdump? It seems to me like it's for a different tool, probably llvm-nm (which simply prints symbol lists). In particular, I don't like the "suppresses other options" bit of the help message. llvm-objdump and llvm-readobj usually just do everything that's asked of them.

The additional supporting options belong in independent patches, based on the first. If you switch to using llvm-nm, you'll find that you probably won't need the --exclude-weak option, since llvm-nm already has a --no-weak option. In fact, you may be able to get away without a new option for --export-unique-symbol, by using existing llvm-nm options, such as --dynamic, I'm not sure.

Please take a look at llvm-nm, and see what you think.



================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:391
 XCOFF ONLY OPTIONS AND COMMANDS
----------------------------------
 
----------------
This is an unrelated fix and should be committed separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112735/new/

https://reviews.llvm.org/D112735



More information about the llvm-commits mailing list