[PATCH] D111034: [AArch64] Optimize add/sub with immediate

[Ben Shi via Phabricator via llvm-commits]

benshi001 added a comment.

In D111034#3099970 <https://reviews.llvm.org/D111034#3099970>, @jaykang10 wrote:

> In D111034#3099926 <https://reviews.llvm.org/D111034#3099926>, @benshi001 wrote:
>
>> In D111034#3099892 <https://reviews.llvm.org/D111034#3099892>, @jaykang10 wrote:
>>
>>> In D111034#3099847 <https://reviews.llvm.org/D111034#3099847>, @benshi001 wrote:
>>>
>>>> In D111034#3069427 <https://reviews.llvm.org/D111034#3069427>, @jaykang10 wrote:
>>>>
>>>>> Sorry, my patch could cause the problem. I have pushed a bug patch https://reviews.llvm.org/D109963. 
>>>>> Please wait a couple of days to verify the bug patch and then rebase your patch.
>>>>
>>>> I have rebased on your newest code and uploaded my patch, it works without any crashes on my localhost.
>>>>
>>>> So if there is no concerns within several days, I will commit my new patch and wait for blames (if there will be). ^_^
>>>
>>> Thanks for rebase and sorry for adding more codes to the pass.
>>>
>>> If possible, please check the bootstrap build and check-all on AArch64 machine to minimize the possibility of errors from AArch64 crews side. If you already did it, I am +1. :)
>>
>> I do not have an aarch64 machine, maybe I need to buy a raspberry-pi or macbook pro m1 for that. :)
>
> Ah, ok. @DavidSpickett mentioned to use docker on https://reviews.llvm.org/D109963 as below.
>
>   If you have docker:
>   
>   $ docker pull linaro/ci-arm64-tcwg-llvmbot-ubuntu:bionic
>   $ docker run -it --entrypoint=/bin/bash linaro/ci-arm64-tcwg-llvmbot-ubuntu:bionic
>   root at a9e83ff71f75:/# export CC=/usr/local/clang+llvm-12.0.0-aarch64-linux-gnu/bin/clang
>   root at a9e83ff71f75:/# export CXX=/usr/local/clang+llvm-12.0.0-aarch64-linux-gnu/bin/clang++
>   <follow commands from the buildbot page>
>   I suggest following https://lab.llvm.org/buildbot/#/builders/179/builds/1234 because it's the simplest. (not by much, it just doesn't use lld)

I am not familiar with docker, but I guess I still need a real phsical aarch64 machine ?

  ben.shi at BJDT046:~$ docker run -it --entrypoint=/bin/bash linaro/ci-arm64-tcwg-llvmbot-ubuntu:bionic
  
  WARNING: The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64) and no specific platform was requested
  standard_init_linux.go:228: exec user process caused: no such file or directory

I tried to pull and launch your suggested docker image on an amd64-linux desktop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111034/new/

https://reviews.llvm.org/D111034