[PATCH] D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/ARM/debug-vars-dwarf4.s:48
 # RUN:     FileCheck %s --check-prefix=ASCII --strict-whitespace
+# RUN:     not llvm-objdump - -d --debug-vars=bad_value 2>&1 | \
+# RUN:     FileCheck %s --check-prefix=ERROR
----------------
I don't think this is going to do what you think it will.

I //think// you're trying to feed the llvm-mc output into llvm-objdump (the `-` means read input from stdin), but you aren't piping any llvm-mc output into llvm-objdump.


================
Comment at: llvm/test/tools/llvm-objdump/dwarf_invalid.yaml:1
+## Test parsing of --dwarf=frames
+
----------------
This comment is out-of-date, given the contents and test name.

There is already testing of --dwarf=frames output for llvm-objdump. You only need to check the invalid value case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112183/new/

https://reviews.llvm.org/D112183