[PATCH] D111034: [AArch64] Optimize add/sub with immediate

Mon Nov 1 03:44:14 PDT 2021

benshi001 added a comment.

In D111034#3099892 <https://reviews.llvm.org/D111034#3099892>, @jaykang10 wrote:

> In D111034#3099847 <https://reviews.llvm.org/D111034#3099847>, @benshi001 wrote:
>
>> In D111034#3069427 <https://reviews.llvm.org/D111034#3069427>, @jaykang10 wrote:
>>
>>> Sorry, my patch could cause the problem. I have pushed a bug patch https://reviews.llvm.org/D109963. 
>>> Please wait a couple of days to verify the bug patch and then rebase your patch.
>>
>> I have rebased on your newest code and uploaded my patch, it works without any crashes on my localhost.
>>
>> So if there is no concerns within several days, I will commit my new patch and wait for blames (if there will be). ^_^
>
> Thanks for rebase and sorry for adding more codes to the pass.
>
> If possible, please check the bootstrap build and check-all on AArch64 machine to minimize the possibility of errors from AArch64 crews side. If you already did it, I am +1. :)

I do not have an aarch64 machine, maybe I need to buy a raspberry-pi or macbook pro m1 for that. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111034/new/

https://reviews.llvm.org/D111034