[PATCH] D112851: [PassManager] `buildModuleOptimizationPipeline()`: schedule `LoopDeletion` pass run before vectorization passes

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 01:20:41 PDT 2021


lebedev.ri added a subscriber: dmgreen.
lebedev.ri added a comment.

In D112851#3099588 <https://reviews.llvm.org/D112851#3099588>, @mkazantsev wrote:

> Deletion of loops before they are vectorized absolutely makes sense to me. Please give it couple more days just in case if someone has concerns regarding the regressions, but making vectorizer run on empty doesn't sound. Please give it 2-3 days to hear others' concerns.

Indeed, even if/when what @aeubanks suggested in https://reviews.llvm.org/D112840#3097891 is implemented,
somehow i don't think it will alleviate the need for *this*-late LoopDeletion.

Thank you for the review, i'll wait a bit on @aeubanks / @asbirlea / @dmgreen,
though given just how little of a compile-time regression this has become,
i can't imagine this will be blocked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112851/new/

https://reviews.llvm.org/D112851



More information about the llvm-commits mailing list