[PATCH] D112276: [InstCombine] Fold `(c & ~(a | b)) | (b & ~(a | c))` to `~a & (b ^ c)`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 25 09:48:03 PDT 2021


lebedev.ri added a comment.

In D112276#3084845 <https://reviews.llvm.org/D112276#3084845>, @anton-afanasyev wrote:

> In D112276#3084757 <https://reviews.llvm.org/D112276#3084757>, @spatel wrote:
>
>> We do have semi-standard pattern matching in AIC outside of the TruncInstCombiner - it lives under "foldUnusualPatterns()".
>
> Oh, sure, forget about it, it has only few folding patterns. As for this, I vote for moving such large boolean pattern to AIC, at least, if we do not need it at "O2 <https://reviews.llvm.org/owners/package/2/>" right now.

For proper boolean solver (which i also suggested having some time ago), sure, AIC sounds like the place,
but the pattern at hand doesn't look all that big actually, to warrant not being here, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112276/new/

https://reviews.llvm.org/D112276



More information about the llvm-commits mailing list