[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

[Shraiysh via Phabricator via llvm-commits]

shraiysh added inline comments.


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:1246
+    StringRef memOrder = op.memory_order().getValue();
+    if (memOrder.equals("acq_rel") || memOrder.equals("release"))
+      return op.emitError(
----------------
shraiysh wrote:
> peixin wrote:
> > Please also check OpenMP 5.1 Spec. It seems that `acq_rel` is allowed if read clause is specified.
> Thanks for this observation, I will update it with the 5.1 standard.
Just to be clear, the OpenMP 5.1 specification changes atomic by a considerable amount (especially it breaks capture into two sub-constructs (coming as a separate patch)) and AFAIK we are targeting OpenMP 5.0. So, do I still update it to the 5.1 standard (this will affect further implementation of atomic construct)? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111992/new/

https://reviews.llvm.org/D111992