[PATCH] D112896: [fir] Add fir.insert_on_range conversion

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:72
+                  mlir::ConversionPatternRewriter &rewriter) const final {
+    mlir::Type ty = this->convertType(op.getType());
+    return doRewrite(op, ty, adaptor, rewriter);
----------------
Seem like this line is the entire justification for this class? Is this enough for it be pulling its weight?

Previously added pattern (`GlobalOpConversion`) started with `    auto tyAttr = convertType(global.getType());` ; should it inherit from this class as well or do I miss something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112896/new/

https://reviews.llvm.org/D112896