[PATCH] D112693: [SimplifyCFG] Fix miscompile in tryWidenCondBranchToCondBranch. PR52290

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 31 21:41:03 PDT 2021


mkazantsev added a comment.

Philip, the bug was indeed revealed on attempt to change the frontend, but there was no bug in initial IR. You are right that widenable condition does not require anything specific be down the false path. But guard widening does. All deopts are mutually replacable, but you can't replace a deopt with a random branch just because there is a widenable condition elsewhere. This makes SimplifyCFG somewhat mad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112693/new/

https://reviews.llvm.org/D112693



More information about the llvm-commits mailing list